Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encapsulate extension helpers #1725

Merged
merged 2 commits into from
Feb 17, 2022
Merged

Encapsulate extension helpers #1725

merged 2 commits into from
Feb 17, 2022

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Feb 12, 2022

As mentioned in #1708, some extensions from the SDK expose internal methods publicly. From what I can tell this includes sentry-rails's ActiveJob integration and sentry-resque. This fixes the issue.

@st0012 st0012 added this to the 5.2.0 milestone Feb 12, 2022
@st0012 st0012 self-assigned this Feb 12, 2022
@st0012 st0012 added this to In progress in 5.x via automation Feb 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2022

Codecov Report

Merging #1725 (90e9f1f) into master (623d046) will increase coverage by 0.01%.
The diff coverage is 98.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1725      +/-   ##
==========================================
+ Coverage   98.40%   98.41%   +0.01%     
==========================================
  Files         141      141              
  Lines        8012     8019       +7     
==========================================
+ Hits         7884     7892       +8     
+ Misses        128      127       -1     
Impacted Files Coverage Δ
sentry-resque/lib/sentry/resque.rb 97.14% <96.66%> (-2.86%) ⬇️
sentry-rails/lib/sentry/rails/active_job.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/background_worker.rb 100.00% <0.00%> (+5.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 623d046...90e9f1f. Read the comment docs.

@lewispb
Copy link
Contributor

lewispb commented Feb 13, 2022

LGTM!

@st0012 st0012 merged commit 7197bd0 into master Feb 17, 2022
@st0012 st0012 deleted the encapsulate-extensions branch February 17, 2022 18:06
5.x automation moved this from In progress to Done Feb 17, 2022
@st0012 st0012 modified the milestones: 5.2.0, 5.1.1 Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
5.x
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants