Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if ActiveRecord connection exists before calling AR connection pool #1769

Merged
merged 2 commits into from
Mar 22, 2022
Merged

Check if ActiveRecord connection exists before calling AR connection pool #1769

merged 2 commits into from
Mar 22, 2022

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Mar 20, 2022

Fixes #1745

@st0012 st0012 added this to the 5.3.0 milestone Mar 20, 2022
@st0012 st0012 added this to In progress in 5.x via automation Mar 20, 2022
@st0012 st0012 self-assigned this Mar 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2022 •
edited

Codecov Report

Merging #1769 (f02936b) into master (4352445) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1769      +/-   ##
==========================================
+ Coverage   98.44%   98.45%   +0.01%     
==========================================
  Files         144      144              
  Lines        8439     8441       +2     
==========================================
+ Hits         8308     8311       +3     
+ Misses        131      130       -1
Impacted Files Coverage Δ
sentry-rails/lib/sentry/rails/background_worker.rb 85.71% <100.00%> (-14.29%) ⬇️
sentry-ruby/lib/sentry/background_worker.rb 100.00% <0.00%> (+5.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4352445...f02936b. Read the comment docs.

@st0012 st0012 mentioned this pull request Mar 20, 2022
Closed
@st0012 st0012 merged commit 51487df into master Mar 22, 2022
5.x automation moved this from In progress to Done Mar 22, 2022
@st0012 st0012 deleted the fix-#1745 branch March 22, 2022 12:59
@matthewrfindley matthewrfindley mentioned this pull request Oct 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sl0thentr0py sl0thentr0py sl0thentr0py approved these changes

Assignees

@st0012 st0012

Labels
sentry-rails
Projects
5.x
Done
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.

exception happened in background worker: ActiveRecord::ConnectionNotEstablished
3 participants
@st0012 @codecov-commenter @sl0thentr0py