Register SentryContextClientMiddleware on sidekiq workers #1774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1774 +/- ##
==========================================
+ Coverage 98.38% 98.41% +0.03%
==========================================
Files 144 145 +1
Lines 8462 8562 +100
==========================================
+ Hits 8325 8426 +101
+ Misses 137 136 -1
Continue to review full report at Codecov.
|
sl0thentr0py
added a commit
that referenced
this pull request
Sep 28, 2023
…s and retries [#2118](#2118) #1774 added `SentryContextClientMiddleware` to the server middleware chain too. Sidekiq's scheduler pushes to the client on the server again for schedules and retries which causes our trace propagation to be broken for this case. https://github.com/sidekiq/sidekiq/blob/aadc77a172f1490fb141c7936d2801ca3af925ef/lib/sidekiq/scheduled.rb#L39 Prioritize taking the trace propagation headers from the job whenever they exist.
sl0thentr0py
added a commit
that referenced
this pull request
Sep 28, 2023
…s and retries [#2118](#2118) (#2118) #1774 added `SentryContextClientMiddleware` to the server middleware chain too. Sidekiq's scheduler pushes to the client on the server again for schedules and retries which causes our trace propagation to be broken for this case. https://github.com/sidekiq/sidekiq/blob/aadc77a172f1490fb141c7936d2801ca3af925ef/lib/sidekiq/scheduled.rb#L39 Prioritize taking the trace propagation headers from the job whenever they exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This configuration was missing in order to support the scenario where a sidekiq job itself pushes new jobs.
This meant that although the Sentry user was propagated from the client to the sidekiq server when running a job, it was not propagated again to any new jobs launched from this worker.
This is what is recommend as per sidekiq's documentation