Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sentry-rails's tracing spans not nesting issue #1784

Merged
merged 5 commits into from
Apr 9, 2022
Merged

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Apr 4, 2022

Fixes #1723

Before

截圖 2022-04-04 21 19 01

After

截圖 2022-04-04 21 19 15

@st0012 st0012 added this to the 5.3.0 milestone Apr 4, 2022
@st0012 st0012 added this to In progress in 5.x via automation Apr 4, 2022
@st0012 st0012 self-assigned this Apr 4, 2022
@st0012 st0012 changed the title Fixes sentry-rails's tracing spans not nesting issue Fix sentry-rails's tracing spans not nesting issue Apr 4, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2022

Codecov Report

Merging #1784 (42308ad) into master (72396ce) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1784      +/-   ##
==========================================
- Coverage   98.41%   98.41%   -0.01%     
==========================================
  Files         145      145              
  Lines        8562     8559       -3     
==========================================
- Hits         8426     8423       -3     
  Misses        136      136              
Impacted Files Coverage Δ
...ls/lib/sentry/rails/tracing/abstract_subscriber.rb 74.07% <100.00%> (-2.60%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72396ce...42308ad. Read the comment docs.

@st0012 st0012 force-pushed the add-sentry-with-child-span branch from 0807404 to 4af72c0 Compare April 8, 2022 08:28
Base automatically changed from add-sentry-with-child-span to master April 8, 2022 08:36
@st0012 st0012 merged commit c735744 into master Apr 9, 2022
5.x automation moved this from In progress to Done Apr 9, 2022
@st0012 st0012 deleted the fix-#1723 branch April 9, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
5.x
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants