Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix net-http tracing's span nesting issue #1796

Merged
merged 2 commits into from
Apr 25, 2022
Merged

Fix net-http tracing's span nesting issue #1796

merged 2 commits into from
Apr 25, 2022

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Apr 23, 2022

As mentioned in #1723 (comment), net-http spans should attach to the current span instead of always the top-level transaction.

@st0012 st0012 added this to the 5.3.0 milestone Apr 23, 2022
@st0012 st0012 added this to In progress in 5.x via automation Apr 23, 2022
@st0012 st0012 self-assigned this Apr 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2022

Codecov Report

Merging #1796 (dac0bc3) into master (942f645) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1796      +/-   ##
==========================================
+ Coverage   98.41%   98.42%   +0.01%     
==========================================
  Files         145      145              
  Lines        8576     8588      +12     
==========================================
+ Hits         8440     8453      +13     
+ Misses        136      135       -1     
Impacted Files Coverage Δ
sentry-ruby/lib/sentry/net/http.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry/net/http_spec.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/core_ext/object/deep_dup.rb 100.00% <0.00%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 942f645...dac0bc3. Read the comment docs.

@st0012 st0012 merged commit 07084c5 into master Apr 25, 2022
5.x automation moved this from In progress to Done Apr 25, 2022
@st0012 st0012 deleted the fix-span-nesting branch April 25, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
5.x
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants