Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentry.with_child_span should check SDK's initialization state #1819

Merged
merged 2 commits into from
May 14, 2022

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented May 14, 2022

Fixes #1818

@st0012 st0012 added this to the 5.3.1 milestone May 14, 2022
@st0012 st0012 self-assigned this May 14, 2022
@st0012 st0012 added this to In progress in 5.x via automation May 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2022

Codecov Report

Merging #1819 (bc9dea5) into master (0fe8d27) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1819      +/-   ##
==========================================
+ Coverage   98.43%   98.45%   +0.01%     
==========================================
  Files         145      145              
  Lines        8587     8589       +2     
==========================================
+ Hits         8453     8456       +3     
+ Misses        134      133       -1     
Impacted Files Coverage Δ
sentry-ruby/lib/sentry-ruby.rb 96.20% <100.00%> (-0.03%) ⬇️
sentry-ruby/spec/initialization_check_spec.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/breadcrumb.rb 100.00% <0.00%> (+3.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fe8d27...bc9dea5. Read the comment docs.

@st0012 st0012 merged commit 8bd4054 into master May 14, 2022
5.x automation moved this from In progress to Done May 14, 2022
@st0012 st0012 deleted the fix-#1818 branch May 14, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
5.x
Done
Development

Successfully merging this pull request may close these issues.

Sentry.with_child_span didn't handle current scope is nil
2 participants