Implement close API that cleans up state and reverses init logic #1844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only logic not reversed is `apply_patches` which is fine since they already check if the patch is already applied and also no-op if `initialized?` is false.
antonpirker
approved these changes
Jul 12, 2022
|
Can we have these test cases?
|
|
@st0012 let me know if you're happy with the specs! |
st0012
requested changes
Jul 16, 2022
st0012
reviewed
Jul 18, 2022
Codecov Report
@@ Coverage Diff @@
## master #1844 +/- ##
=======================================
Coverage 98.37% 98.38%
=======================================
Files 146 146
Lines 8683 8735 +52
=======================================
+ Hits 8542 8594 +52
Misses 141 141
Continue to review full report at Codecov.
|
st0012
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps some testing environments where they need to init/close around each test and expect the SDK to cleanup state.
The only logic not reversed is
apply_patcheswhich is fine since they already check if the patch is already applied and also no-op ifinitialized?is false.fixes #1842