Set sentry.error_event_id in request env if the middleware captures errors #1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1849 +/- ##
=======================================
Coverage 98.39% 98.39%
=======================================
Files 146 146
Lines 8735 8744 +9
=======================================
+ Hits 8595 8604 +9
Misses 140 140
Continue to review full report at Codecov.
|
grosser
approved these changes
Jul 20, 2022
grosser
reviewed
Jul 21, 2022
| @@ -32,7 +32,9 @@ def capture_exception(exception, env) | |||
| current_scope.set_transaction_name(original_transaction) | |||
| end | |||
|
|
|||
| Sentry::Rails.capture_exception(exception) | |||
| Sentry::Rails.capture_exception(exception).tap do |event| | |||
| env[ERROR_EVENT_ID_KEY] = event.event_id if event | |||
There was a problem hiding this comment.
this should also go into the rack middleware here ?
st0012
commented
Jul 21, 2022
| def capture_exception(exception, _env) | ||
| Sentry.capture_exception(exception) | ||
| def capture_exception(exception, env) | ||
| Sentry.capture_exception(exception).tap do |event| |
There was a problem hiding this comment.
@grosser This also has the same logic.
I had to replicate them in 2 places because the receivers are different: Sentry and Sentry::Rails and I don't want to introduce another abstraction just for the 2 occurrences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will allow users/libraries to implement mechanisms displaying relevant error events' ids. Which will help their users report issues.
Closes #1846