Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec to Backtrace::APP_DIRS_PATTERN #2029

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

sl0thentr0py
Copy link
Member

while working on the profiler, I noticed spec was missing here.

@sl0thentr0py sl0thentr0py force-pushed the neel/add-spec-to-dirs-pattern branch from 73bf4a2 to a02ac29 Compare April 6, 2023 14:25
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (d45f720) 98.58% compared to head (3031948) 98.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2029      +/-   ##
==========================================
- Coverage   98.58%   98.56%   -0.02%     
==========================================
  Files         157      157              
  Lines       10127    10127              
==========================================
- Hits         9984     9982       -2     
- Misses        143      145       +2     
Impacted Files Coverage Δ
sentry-ruby/lib/sentry/backtrace.rb 96.61% <100.00%> (ø)
...try-ruby/spec/sentry/interfaces/stacktrace_spec.rb 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sl0thentr0py sl0thentr0py force-pushed the neel/add-spec-to-dirs-pattern branch from a02ac29 to 62b06c0 Compare April 6, 2023 14:33
Copy link
Collaborator

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker, but we probably should find another non-in-app trace to verify that check.

@st0012 st0012 added this to the 5.9.0 milestone Apr 6, 2023
@sl0thentr0py sl0thentr0py force-pushed the neel/add-spec-to-dirs-pattern branch from 62b06c0 to 3031948 Compare April 6, 2023 14:56
@sl0thentr0py
Copy link
Member Author

added :)

@sl0thentr0py sl0thentr0py merged commit bad263c into master Apr 6, 2023
@sl0thentr0py sl0thentr0py deleted the neel/add-spec-to-dirs-pattern branch April 6, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants