Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename http.method to http.request.method in span data #2106

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Rename http.method to http.request.method in span data #2106

merged 1 commit into from
Sep 12, 2023

Conversation

sl0thentr0py
Copy link
Member

closes #2105

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
sentry-ruby/lib/sentry/span.rb 100.00%

📢 Thoughts on this report? Let us know!.

@sl0thentr0py sl0thentr0py merged commit 1745db2 into master Sep 12, 2023
80 of 98 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/fix-http-method branch September 12, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleptric cleptric cleptric approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Starfish] Add starfish v1 attribute http.request.method to span data
2 participants
@sl0thentr0py @cleptric