Adopt Rails 7.1's new BroadcastLogger #2120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
... and 23 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
st0012
force-pushed
the
update-for-rails-7-1
branch
from
4150339
to
3e04c72
Compare
In rails/rails#48615, Rails 7.1 introduced a new BroadcastLogger class that allows users to send logs to multiple loggers, which means we need to adjust the SDK's logger assignment for it.
st0012
force-pushed
the
update-for-rails-7-1
branch
from
3e04c72
to
821cb94
Compare
sl0thentr0py
approved these changes
Oct 2, 2023
|
It turned out I also found a Rails issue when working on this 😄 rails/rails#49417 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rails/rails#48615, Rails 7.1 introduced a new
BroadcastLoggerclass that allows users to send logs to multiple loggers, which means we need to adjust the SDK's logger assignment for it.