Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send negative line numbers in profiles #2158

Merged
merged 1 commit into from Nov 2, 2023

Conversation

sl0thentr0py
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #2158 (db346f7) into master (1a74734) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2158      +/-   ##
==========================================
+ Coverage   97.30%   97.33%   +0.02%     
==========================================
  Files          97       97              
  Lines        3638     3638              
==========================================
+ Hits         3540     3541       +1     
+ Misses         98       97       -1     
Components Coverage Δ
sentry-ruby 98.02% <100.00%> (ø)
sentry-rails 94.98% <ø> (ø)
sentry-sidekiq 93.70% <ø> (ø)
sentry-resque 93.65% <ø> (+1.58%) ⬆️
sentry-delayed_job 94.36% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files Coverage Δ
sentry-ruby/lib/sentry/profiler.rb 99.11% <100.00%> (ø)

... and 1 file with indirect coverage changes

@sl0thentr0py sl0thentr0py merged commit 7a65d3f into master Nov 2, 2023
98 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/neg-lineno-profiler branch November 2, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants