Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sidekiq-cron job patch return #2176

Merged
merged 1 commit into from Nov 23, 2023
Merged

Conversation

sl0thentr0py
Copy link
Member

#skip-changelog

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #2176 (a932efb) into master (62989c1) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2176      +/-   ##
==========================================
- Coverage   97.34%   97.21%   -0.14%     
==========================================
  Files          98       95       -3     
  Lines        3656     3517     -139     
==========================================
- Hits         3559     3419     -140     
- Misses         97       98       +1     
Components Coverage Δ
sentry-ruby 97.98% <ø> (-0.04%) ⬇️
sentry-rails 94.98% <ø> (ø)
sentry-sidekiq 94.96% <100.00%> (+0.03%) ⬆️
sentry-resque 92.06% <ø> (ø)
sentry-delayed_job 94.36% <ø> (ø)
sentry-opentelemetry ∅ <ø> (∅)
Files Coverage Δ
sentry-sidekiq/lib/sentry/sidekiq/cron/job.rb 93.33% <100.00%> (+0.47%) ⬆️

... and 4 files with indirect coverage changes

@sl0thentr0py sl0thentr0py merged commit 78fb37a into master Nov 23, 2023
97 of 98 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/fix-cron-job-return branch November 23, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants