Implement proper flushing logic on close for sessions and client reports #2206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2206 +/- ##
=======================================
Coverage 97.36% 97.36%
=======================================
Files 101 101
Lines 3792 3798 +6
=======================================
+ Hits 3692 3698 +6
Misses 100 100
|
sl0thentr0py
force-pushed
the
neel/flush
branch
from
a3ac113
to
9aa67fd
Compare
sl0thentr0py
force-pushed
the
neel/flush
branch
from
9aa67fd
to
faf6b0f
Compare
sl0thentr0py
force-pushed
the
neel/flush
branch
from
faf6b0f
to
d334af5
Compare
cleptric
approved these changes
Dec 21, 2023
st0012
added a commit
that referenced
this pull request
Dec 22, 2023
When reviewing #2206, I spotted 2 things that could be improved: - When closing the SDK, we shouldn't need to enqueue the last client report sending to background worker again. This makes the behaviour of `close` more difficult to predict. - Since the session flusher can still enqueue a job to background worker when flushing, we should postpone background worker's shutdown instead.
Merged
st0012
added a commit
that referenced
this pull request
Dec 22, 2023
When reviewing #2206, I spotted 2 things that could be improved: - When closing the SDK, we shouldn't need to enqueue the last client report sending to background worker again. This makes the behaviour of `close` more difficult to predict. - Since the session flusher can still enqueue a job to background worker when flushing, we should postpone background worker's shutdown instead.
jamie-o-wilkinson
added a commit
to alphagov/forms-api
that referenced
this pull request
Jan 19, 2024
It seems as if changes introduced by getsentry/sentry-ruby#2206 were interfering with Sentry test teardown. Fortunately, getsentry/sentry-ruby#1773 adds some test helpers which manage Sentry test setup/teardown, which resolves this issue.
jamie-o-wilkinson
added a commit
to alphagov/forms-admin
that referenced
this pull request
Jan 19, 2024
It seems as if changes introduced by getsentry/sentry-ruby#2206 were interfering with Sentry test teardown. Fortunately, getsentry/sentry-ruby#1773 adds some test helpers which manage Sentry test setup/teardown, which resolves this issue.
jamie-o-wilkinson
added a commit
to alphagov/forms-runner
that referenced
this pull request
Jan 19, 2024
It seems as if changes introduced by getsentry/sentry-ruby#2206 were interfering with Sentry test teardown. Fortunately, getsentry/sentry-ruby#1773 adds some test helpers which manage Sentry test setup/teardown, which resolves this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2193