Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add most scope data to CheckInEvent #2217

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

sl0thentr0py
Copy link
Member

@sl0thentr0py sl0thentr0py commented Jan 4, 2024

I also removed the option to pass &block to the top level Sentry.capture_check_in since that would be useless now (pretty sure no one was using that anyway).

closes #2191

Copy link
Collaborator

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like CheckInEvent shouldn't even inherit Event anymore as we don't want any of the attributes from it anyway?

sentry-ruby/spec/sentry/hub_spec.rb Outdated Show resolved Hide resolved
@sl0thentr0py
Copy link
Member Author

@st0012

It looks like CheckInEvent shouldn't even inherit Event anymore as we don't want any of the attributes from it anyway?

we might introduce a couple back (like tags/extras), we're still iterating on the design, so I don't want to refactor too much. This was mainly to remove breadcrumbs because they caused payload bloat and caused missed check-ins. I removed the other stuff for now and we might back add some later.

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Merging #2217 (74ae08c) into master (918b83d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2217   +/-   ##
=======================================
  Coverage   97.42%   97.42%           
=======================================
  Files         102      102           
  Lines        3800     3801    +1     
=======================================
+ Hits         3702     3703    +1     
  Misses         98       98           
Components Coverage Δ
sentry-ruby 98.13% <100.00%> (+<0.01%) ⬆️
sentry-rails 95.01% <ø> (ø)
sentry-sidekiq 94.70% <ø> (ø)
sentry-resque 92.06% <ø> (ø)
sentry-delayed_job 94.44% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files Coverage Δ
sentry-ruby/lib/sentry-ruby.rb 96.44% <100.00%> (ø)
sentry-ruby/lib/sentry/hub.rb 99.38% <100.00%> (ø)
sentry-ruby/lib/sentry/scope.rb 100.00% <100.00%> (ø)

@sl0thentr0py sl0thentr0py merged commit e02c5fd into master Jan 8, 2024
123 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/scope-apply-checkin branch January 8, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't apply all scope data to check-ins
2 participants