-
-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for distributed tracing for DelayedJob #2233
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2233 +/- ##
==========================================
+ Coverage 97.39% 97.43% +0.03%
==========================================
Files 102 102
Lines 3804 3823 +19
==========================================
+ Hits 3705 3725 +20
+ Misses 99 98 -1
|
354e8fa
to
534730d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of injecting trace data to args, can we maybe use a custom ivar? Like @_sentry_trace_data
. That way the extraction will be easier and we don't need to risk breaking the call completely if the args deletion somehow goes wrong.
we'll need to patch delayed_job's YAML stuff here then, since ivar's are not picked up by default and won't survive the database round trip. so I opted for this, which of the two do you prefer? |
Ah thanks for this context. Let's first go with the current implementation then. |
* only for `PerformableMethod` here, active job will be handled generally separately
Co-authored-by: Stan Lo <stan001212@gmail.com>
cfad4ab
to
8485799
Compare
@@ -1,4 +1,5 @@ | |||
require "bundler/setup" | |||
require "debug" if RUBY_VERSION.to_f >= 2.6 && RUBY_ENGINE == "ruby" | |||
require "pry" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related: do you still use pry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope! I've moved to debugger
if available
PerformableMethod
part of #1904