-
-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metric summaries on span #2255
Metric summaries on span #2255
Conversation
9a6569c
to
6dc3b72
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2255 +/- ##
==========================================
- Coverage 97.56% 97.54% -0.03%
==========================================
Files 111 112 +1
Lines 4060 4108 +48
==========================================
+ Hits 3961 4007 +46
- Misses 99 101 +2
|
b7a6537
to
bf28b5c
Compare
094e4aa
to
e6bbb90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it does the same as Python. (Again, I am no Ruby dev so some things (in tests) look like black magic) But I guess this is ok.
* add a `LocalAggregator` instance on spans to duplicate metrics on the span as a gauge metric * proxy the main aggregator add calls to the local aggregator if a span is running * start a `metrics.timing` span in the `Sentry::Metrics.timing` API
2a4ea74
to
116318b
Compare
LocalAggregator
instance on spans to duplicate metrics on the span as a gauge metricmetric.timing
span in theSentry::Metrics.timing
APIpart of #2246