-
-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mechanism interface and default to handled false in integrations #2280
Conversation
569db7b
to
fe0ed81
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2280 +/- ##
==========================================
- Coverage 97.61% 97.57% -0.04%
==========================================
Files 112 113 +1
Lines 4154 4170 +16
==========================================
+ Hits 4055 4069 +14
- Misses 99 101 +2
|
776afb7
to
6b3bee0
Compare
@@ -29,17 +29,19 @@ def initialize(exception:, stacktrace: nil) | |||
@module = exception.class.to_s.split('::')[0...-1].join('::') | |||
@thread_id = Thread.current.object_id | |||
@stacktrace = stacktrace | |||
@mechanism = mechanism || Mechanism.new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move this default assignment upstream? I think if we assign a default in Hub#capture_exception
as well, then we can just assume mechanism
will always be present when it reached client and interfaces?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved it to Client#event_from_exception
since we'll have to break the signature of that method otherwise since it uses positional and not keyword arguments.
6b3bee0
to
5eb6f42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment left, otherwise it's good.
4e46fc1
to
9130bcc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rubber stamp
closes #1743