Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.x] Retrieve user IP from request context #132

Merged
merged 1 commit into from May 23, 2018
Merged

[1.x] Retrieve user IP from request context #132

merged 1 commit into from May 23, 2018

Conversation

eliecharra
Copy link
Contributor

@eliecharra eliecharra commented May 22, 2018 •
edited

Backport #131 for 1.x

  • Fix test for 1.x as test api changed a little bit

Retrieve user IP from request context
38ecc5f 
This will fix ivalid client IP retrieval when app is behind a
reverse proxy as we retrieve IP through framework logic.
Jean85
Jean85 approved these changes May 23, 2018
View reviewed changes
Copy link
Collaborator

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks again!

@Jean85 Jean85 merged commit b784b79 into getsentry:releases/1.x May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jean85 Jean85 Jean85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eliecharra @Jean85