Make command lazily loaded

[kefzce]

Hi there.
Since Symfony 3.4^ allows us to provide console command name for compile-time registration all console command should be registered by this way, if not
every time when someone run ./bin/console Symfony should compile all container to fetch command name and set parameter manually

Also here is a way to check if on your Symfony project some commands register not properly

bin/console debug:container --parameter=console.command.ids

Example output from my project now

  Parameter             Value                                                            
 --------------------- ----------------------------------------------------------------------------- ------------ 
  console.command.ids   ["console.command.public_alias.Sentry\SentryBundle\Command\SentryTestCommand
 --------------------- ------------------------------------------------------------------------------------------

we are using
"sentry/sentry-symfony": "^3.0" // 3.5.2
This is the simple fix which not breaking BC because BC layer already on \Symfony\Component\Console\Command\Command

Also here some ref where the same problem was fixed by this way

• Lazy console commands doctrine/migrations#839
• Make commands lazily loaded doctrine/DoctrineMongoDBBundle#642

btw, I'm not sure about the target branch, should be 3.5 instead?

[za4me]

LGTM!

[Jean85]

Change LGTM 👍 but I had to change the target branch, so you should drop the additional commits from master.

Please also add a changelog entry too.

[kefzce]

Change LGTM 👍 but I had to change the target branch, so you should drop the additional commits from master.

Please also add a changelog entry too.

Sure, thanks ill rebase pr a bit later from the target branch.

[ste93cry]

Can you please rebase once more and fix the broken build (it should be enough to change the regex of the error message of PHPStan so that instead of hardcoding the version number uses a match pattern)? Also, in the CHANGELOG can you please add a reference to this PR?

[kefzce]

Can you please rebase once more and fix the broken build (it should be enough to change the regex of the error message of PHPStan so that instead of hardcoding the version number uses a match pattern)? Also, in the CHANGELOG can you please add a reference to this PR?

Sure. no problem.

[Jean85]

Thank you for your contribution!