Allow PHP 8 #399
Merged
Allow PHP 8 #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Jean85 In this pr - only update Symfony max version code and add allow PHP8 |
Merged
|
Ok it's confirmed that that's not your fault: https://github.com/getsentry/sentry-symfony/pull/400/checks?check_run_id=1563568113 I'll try to fix the build in #400 |
marmichalski
approved these changes
Dec 17, 2020
|
@Yozhef can you please try rebasing this PR and see if the CI passes? |
|
@ste93cry merge master normal or need only rebasing? |
Jean85
approved these changes
Dec 22, 2020
This was referenced Jan 4, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.