Reorganize the folder structure and apply new CS standard #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ste93cry
force-pushed
the
reorganize-folder-structure-and-apply-new-cs-standard
branch
2 times, most recently
from
54eb3d6
to
07beb86
Compare
I agree: the End2End tests serve the same purposes and are automatically aligned with the code. |
ste93cry
force-pushed
the
reorganize-folder-structure-and-apply-new-cs-standard
branch
from
07beb86
to
9c76713
Compare
Jean85
requested changes
Jan 4, 2021
ste93cry
force-pushed
the
reorganize-folder-structure-and-apply-new-cs-standard
branch
from
4714aee
to
8625fbf
Compare
Jean85
approved these changes
Jan 5, 2021
ste93cry
deleted the
reorganize-folder-structure-and-apply-new-cs-standard
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title, I've aligned both the CS standard and the folder structure with the one used in the main SDK. The only notable change is the introduction of
declare(strict_types=1)in all files. I also deleted the wholeexamplesfolder as I judged it useless, unmaintained, and because I think it's better to improve the documentation rather than providing yet another copy of a basic Symfony app that I don't understand how it can help new users