Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the config section related to Monolog #406

Merged
merged 1 commit into from Jan 7, 2021

Conversation

ste93cry
Copy link
Collaborator

@ste93cry ste93cry commented Jan 6, 2021

I cannot think of any reason for keeping the sentry.monolog configuration option as it doesn't offer any benefit over registering the service by hands. Since changing the Monolog configuration is too hard and cannot be done in an automatic way, the user has anyway to edit the configuration files to add the service to the Monolog handlers stack and at that point having to write the service definition imo is the least. Last, registering the service by hands will make it possible to set environment variables as values of the constructor of the handler, rather than us having to provide workarounds to support this feature in the configuration (#384)

@ste93cry ste93cry force-pushed the remove-monolog-config-section branch from 051c42a to 5fb81b4 Compare January 6, 2021 11:41
Copy link
Collaborator

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this. It will fail hard on update so it's easy to change, and we can later reintroduce it better if we will work on #337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants