Prefer usage of the existing HttpMessageFactoryInterface service for the RequestFetcher class #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the RequestFetcher class
ste93cry
force-pushed
the
request-fetcher-use-public-http-message-factory-service
branch
from
ede98c4
to
6e399a6
Compare
Jean85
approved these changes
Jan 13, 2021
ste93cry
deleted the
request-fetcher-use-public-http-message-factory-service
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really small change to make the
RequestFetcherclass to prefer the existingSymfony\Bridge\PsrHttpMessage\HttpMessageFactoryInterfaceservice rather than using an anonymous service forcefully constructed on-the-fly