Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Mono PDB files upload during build #1106

Merged
merged 5 commits into from
Dec 14, 2022
Merged

feat: Mono PDB files upload during build #1106

merged 5 commits into from
Dec 14, 2022

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Dec 6, 2022 •
edited
Loading

Closes #1053
This can already be merged but will only start having an effect with getsentry/sentry-dotnet#2050

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 4c92641

@vaind vaind changed the title feat: Mono line number support feat: Mono PDB files upload during build Dec 7, 2022
@vaind vaind marked this pull request as ready for review December 7, 2022 13:40
bruno-garcia
bruno-garcia reviewed Dec 8, 2022
View reviewed changes
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't require a bump on sentry-cli?

src/Sentry.Unity.Editor/Sentry.Unity.Editor.csproj
@@ -9,6 +9,7 @@
<ProjectReference Include="../sentry-dotnet/src/Sentry/Sentry.csproj" Private="false" IncludeAssets="compile" />
<ProjectReference Include="../Sentry.Unity/Sentry.Unity.csproj" Private="false" IncludeAssets="compile" />
<PackageReference Include="Mono.Cecil" Version="0.11.4" Private="false" />
<PackageReference Include="Microsoft.Extensions.FileSystemGlobbing" Version="7.0.0" Private="false" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

src/Sentry.Unity.Editor/Native/BuildPostProcess.cs Outdated Show resolved Hide resolved
@bruno-garcia
Copy link
Member

And what do we do with 2019?

@vaind vaind mentioned this pull request Dec 8, 2022
Merged
8 tasks
@vaind
Copy link
Collaborator Author

vaind commented Dec 8, 2022

And what do we do with 2019?

Not much I could think of - say we don't support line numbers there - isn't it the same for IL2CPP?

@bruno-garcia
Copy link
Member

This is up to @bitsandfoxes

@vaind
Copy link
Collaborator Author

vaind commented Dec 8, 2022

Doesn't require a bump on sentry-cli?

We are on the latest one here.

@bitsandfoxes
Copy link
Contributor

And what do we do with 2019?

tbh I would not put any more energy into 2019 than not breaking it.

@vaind vaind merged commit e03790d into main Dec 14, 2022
@vaind vaind deleted the feat/mono-line-numbers branch December 14, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruno-garcia bruno-garcia bruno-garcia left review comments

@bitsandfoxes bitsandfoxes bitsandfoxes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Line Numbers missing with Mono
3 participants
@vaind @bruno-garcia @bitsandfoxes