Skip to content
This repository has been archived by the owner on Nov 20, 2023. It is now read-only.

chore: update @sentry/cli to latest major version #363

Merged
merged 1 commit into from Apr 14, 2022

Conversation

sawilde
Copy link
Contributor

@sawilde sawilde commented Apr 14, 2022

update @sentry/cli to latest major version

why

because new users to @sentry/cli will be pulling that major version and if they also use the plugin they'll now have two versions installed - it is probably not an issue but it is damn confusing to have two major versions in the yarn.lock file

@kamilogorek kamilogorek merged commit 96f6ba5 into getsentry:master Apr 14, 2022
@kamilogorek
Copy link
Contributor

Thanks 🙇

@sawilde sawilde deleted the chore/upgrade_sentry_cli branch April 14, 2022 19:51
@sawilde
Copy link
Contributor Author

sawilde commented Apr 14, 2022

nw

however, why did you accept the pull request with a broken build (not like I see it breaking but...)? Seems Sentry 2.x is now only happy with Node 12 and above - IIRC this means we also need to change the matrix in the actions from

node: [8, 10, 12]

to something like

node: [12, 14, 16]

It would also mean a breaking change so an upgrade to the major version number before any publish to npm/github.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants