Skip to content
This repository has been archived by the owner on Nov 20, 2023. It is now read-only.

ref: Update sentry-cli and refresh GH actions #368

Merged
merged 2 commits into from
Apr 26, 2022
Merged

Conversation

kamilogorek
Copy link
Contributor

99% of changes are automatic formatting changes. Only relevant change is bumping @sentry/cli from 1.74.3 to 1.74.4

@kamilogorek kamilogorek force-pushed the update-cli branch 2 times, most recently from 0f7395c to 70bf094 Compare April 26, 2022 12:56
@kamilogorek kamilogorek changed the title ref: Update all deps, including cli itself; Refresh CI config ref: Update sentry-cli and refresh GH actions Apr 26, 2022
@@ -18,7 +18,7 @@
"node": ">= 8"
},
"dependencies": {
"@sentry/cli": "^2.0.2"
"@sentry/cli": "^1.74.4"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is downgrading @sentry/cli from v2 to v1. Is this intentional?
The release notes say that the major version was upgraded, but the reality is that in 1.18.9 release we are still stuck with @sentry/cli v1 😕
cc @sawilde

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing that out, changelog is incorrect; updated it.
We stick to v1 for now, as v2 has minimal version of node set to 12, which is not the case for this plugin.
We'll update major once we decide to move the plugin to the next major as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nw - thanks for the update

would the alternative be - as horrid it may sound - to have two branches one supporting v1 and the other v2 of @sentry/cli? I've seen other packages do something similar but not sure on how maintainable it would be for the team.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are definitely going to have v1 and v2, however, it still requires doing some work and major release, which I don't have enough capacity for right now.
This is precisely how we handle this in sentry-cli, and why we can stick to v1 here:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants