fix: Fix platform selection issues and repeated prompts #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass answers to this.shouldConfigure
bruno-garcia
approved these changes
Apr 29, 2021
iker-barriocanal
approved these changes
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues that have been reported by users about getting stuck in the platform step, or getting spammed with the same repeated platform question with then their platform selection not actually being used.
Fixes #93, getsentry/sentry-react-native#1386.
Fixed by passing
_answerstothis.shouldConfigureinthis.shouldEmit. Also requires_answersto be defined as a parameter inshouldConfigure.Tested by running on a React Native sample app and a Cordova sample app.