Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make delta in past timestamp check configurable #12420

Open
nitely opened this issue Mar 15, 2019 · 5 comments
Open

Make delta in past timestamp check configurable #12420

nitely opened this issue Mar 15, 2019 · 5 comments

Comments

@nitely
Copy link

nitely commented Mar 15, 2019

Summary

The current delta is 30 days. Reports older than 30 days will show a Discarded invalid value for parameter 'timestamp' Collapse error and the timestamp get set to the current time. I need reports older than 30 days (but not much older) to keep the original datetime.

Motivation

The project I'm working on sometimes receives old logs, older than 30 days (usually 45 days or so). I want them to keep the original timestamp. I'm aware the original timestamp can be found at asctime field. But I don't want old reports to show as they were generated today. The checking is still useful in cases were the clock is way off, I just want to increase the delta.

Additional Context

If I'm not mistaken, the check can be found here, the current value is hard coded to 30 days.

@BYK
Copy link
Contributor

BYK commented Oct 21, 2020

Closing this issue due to staleness. Feel free to comment here if you think we should still work on this.

@BYK BYK closed this as completed Oct 21, 2020
@astrojuanlu
Copy link

It would be a nice addition, yes. I looked at this issue a few hours ago to see if there was progress (or more upvotes)

@iliya-timofeev
Copy link

I also would like to vote for this issue.

@BYK
Copy link
Contributor

BYK commented Oct 26, 2020

@astrojuanlu @iliya-timofeev - I think this wouldn't be too complex to implement through our configuration system. Would you be willing to submit a PR?

PR: I don't think we can change this for sentry.io though, so the configuration would only make sense for self-hosted Sentry. /cc @mattrobenolt @JTCunning to verify.

@BYK BYK reopened this Oct 26, 2020
@mattrobenolt
Copy link
Contributor

There's no technical reason we can't do this in SaaS, but frankly the UX for this is way too confusing. It's already confusing enough allowing anything in the past.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants