Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error still upload even if do not invoke captureException #13409

Closed
1 of 3 tasks
Symous opened this issue May 27, 2019 · 4 comments
Closed
1 of 3 tasks

Error still upload even if do not invoke captureException #13409

Symous opened this issue May 27, 2019 · 4 comments

Comments

@Symous
Copy link

Symous commented May 27, 2019

Important Details

How are you running Sentry?

  • On-Premise docker [Version xyz]
  • Saas (sentry.io)
  • Other [briefly describe your environment]

Description

I can not confirm whether it is a bug that if we once used captureException to report error to sentry and after that even if we remove the captureException code, the error is still uploaded to sentry. what happened?

Steps to Reproduce

  1. [First Step]
    use captureException to report an error.
  2. [Second Step]
    remove or comment the above captureException code.
  3. and so on.
    Still can see the new uploaded error.
    Good items to include here include:

What you expected to happen

The error is not supposed to uploaded to Sentry Issues since we have remove the captureException

Version

Sentry: @sentry/browser 5.3.0
React: 16.8.6

@markstory
Copy link
Member

Have you made sure that the global onerror handlers are also not attached?

@Symous
Copy link
Author

Symous commented May 28, 2019

@markstory thanks for your reply, I do not set a window.onerror handler or any onerror options to sentry initialization. But I have read from the document that:

Automatically Capturing Errors
By including and configuring the Sentry Browser SDK, Sentry will automatically attach global handlers to capture uncaught exceptions and unhandled rejections.

Is that means the error will upload automatically even I do not use captureException ? and I also have tested captureUnhandledRejections :true, but it seems like that not working as excepted.

@markstory
Copy link
Member

markstory commented May 28, 2019

Is that means the error will upload automatically even I do not use captureException ?

Yes, that behavior comes from one of the default integrations. You can disable the default integrations if you want. Here are the default integrations with some examples on how to disable specific ones.

@BYK
Copy link
Contributor

BYK commented Oct 22, 2020

Closing this issue due to staleness. Feel free to comment here if you think we should still work on this.

@BYK BYK closed this as completed Oct 22, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants