Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limitations on SENTRY_KEY not documented #22

Closed
thraxil opened this issue Oct 7, 2010 · 2 comments · Fixed by #25
Closed

Limitations on SENTRY_KEY not documented #22

thraxil opened this issue Oct 7, 2010 · 2 comments · Fixed by #25

Comments

@thraxil
Copy link
Contributor

thraxil commented Oct 7, 2010

I assumed that SENTRY_KEY was just any random string that should be unique to a deployment and kept secret (ie, serving a similar purpose to django's SECRET_KEY) so I generated a random string to use there.

It turns out that it's used in a URL for the feeds:

url(r'^feeds/%s/messages.xml$' % KEY, MessageFeed(), name='sentry-feed-messages'),

(in sentry.urls)

Mine happened to have an '[' in it which caused a very confusing error about an unterminated regex.

It should be documented that SENTRY_KEY will make it into a URL (and further that django will try to then parse it as a regexp when trying to do reverse lookups) and thus can't have most punctuation.

@cburgmer
Copy link

cburgmer commented Oct 8, 2010

I have prepared a patch that fixes the regex parts so you would be allowed to pass meta characters.

@cburgmer
Copy link

cburgmer commented Oct 8, 2010

Still wondering how to upload here though.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2020
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants