Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist Platforms #2353

Closed
dcramer opened this issue Nov 23, 2015 · 0 comments
Closed

Whitelist Platforms #2353

dcramer opened this issue Nov 23, 2015 · 0 comments
Assignees
Milestone

Comments

@dcramer
Copy link
Member

dcramer commented Nov 23, 2015

Right now platforms are arbitrary, but that's not actually true in Sentry. We have strongly keyed names for the language support, and SDKs need to reflect that to maintain behavior.

We should create an internal whitelist of known language keys, and if a platform does not match that, we'll simply treat it as "other". It may we still store the raw value, but the system wouldn't recognize it outside of that.

As part of this we should also take care of #1329 and document the language keys and their reasoning.

@dcramer dcramer added this to the 8.0 Release milestone Nov 23, 2015
@dcramer dcramer self-assigned this Nov 23, 2015
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant