Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard event listeners for replay playback (aka: shortcuts) #37934

Open
ryan953 opened this issue Aug 17, 2022 · 1 comment
Open

Keyboard event listeners for replay playback (aka: shortcuts) #37934

ryan953 opened this issue Aug 17, 2022 · 1 comment

Comments

@ryan953
Copy link
Member

ryan953 commented Aug 17, 2022

Depending on the replay duration, skipping through the session can be a finicky experience.
Power users, and would prefer to use keyboard short

The problem is that people familiar with Youtube and other video playing sites (basically everyone) expect to be able to play/pause the replay using their keyboard. Typically with the spacebar.

Power users would also benefit from other shortcuts that make it easier to scrub through the replay, and across the page.

We should come up with a set of keyboard shortcuts that the page will support and make them available at all times, whether the user is in full screen mode or not.

Some keys to start with:

  • Spacebar to toggle play/pause on the replayContext
  • left & right arrow keys to skip forward/backward 10s
  • shift+left & shift+right to jump forwards and backwards to the next chapter/breadcrumb

maybe some more

We will need to make sure that keys don't conflict with each other. And that if someone is typing into a text box (to filter Console for example) shortcuts are not triggered.

@danecando danecando self-assigned this Aug 19, 2022
@Jesse-Box Jesse-Box changed the title Player should have a page-wide keyboard event listener so people can stop/start the video no matter where the focus is set Keyboard event listeners for replay playback Nov 15, 2022
@c298lee c298lee self-assigned this Nov 8, 2023
@ryan953
Copy link
Member Author

ryan953 commented Nov 21, 2023

We should also talk about what happens if the replay is playable on the Issue Details page
and also how we teach people what the shortcuts are... is there a popup somewhere that has a list? idk!

@bruno-garcia bruno-garcia changed the title Keyboard event listeners for replay playback Keyboard event listeners for replay playback (aka: shortcuts) Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants