Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag inconsistency between platforms #46574

Closed
igorsantos07 opened this issue Mar 30, 2023 · 5 comments
Closed

Tag inconsistency between platforms #46574

igorsantos07 opened this issue Mar 30, 2023 · 5 comments

Comments

@igorsantos07
Copy link

igorsantos07 commented Mar 30, 2023

Environment

SaaS (https://sentry.io/)

Version

No response

Link

No response

DSN

No response

Steps to Reproduce

We have a project that runs on three different platforms, Sentry-wise: the backend is PHP, the frontend is React, and there's also a Cordova-based native app which runs the same React codebase, pre-packed. Thus, we have three different places to configure Sentry, and........... Each report is slightly different from the other, making it hard to distinguish between the three. I guess this is related to how each Sentry client evolved throughout the time, but this needs some review. This is somewhat related to an early report I made about messy tags and mixed up projects - #46362 and #46364.

Expected Result

All reports should have a known tag which clearly states its origin platform. Not sure why Cordova has event.origin but the others (not even the JS report) don't. Bonus points if that platform is recognized by the system and shows an icon, instead of relying on the platform I selected for the project (good suggestion for #46364).

I shouldn't have to manually add logger: xyz for it to show somewhat organized on my panel. Glad I "debugged" the Sentry interface/tags and noticed how to fix it by myself 👀 Actually, even if I manually add logger:cordova to a report and it filters just like logger:php would do, it does not show on the Issues list, so it seems like the issue is kinda deeper 🤦‍♂️

Actual Result

A Cordova report is recognized by event.origin:cordova, but event.environment:javascript might be a bit deceptive, although understandable once you see the origin is Cordova. And here, mechanism:onunhandledrejection is a bit more meaningful than the others below.

A JS report is recognized by... nothing? There's mechanism:http.client, which I guess I can consider a JS smell, since I know it's a JS report and that's only present only in the JS report. No clue what are the mechanism tags, though, and I didn't find docs about that.

A PHP report is recognized by having php besides "First Seen" in the issues list, and inside the report by the repetitive logger:php / runtime.name:php (I guess the latter exists for situations where you're using HHVM and other runtimes?). It seems that php from the list comes from the logger tag, but that's also not obvious, I had to check the URL it links to. Lastly, mechanism:generic doesn't say much here and I have no clue what's the difference between that and JS's http.client.

@getsantry
Copy link
Contributor

getsantry bot commented Mar 30, 2023

Assigning to @getsentry/support for routing, due by Thursday, March 30th at 5:00 pm (sfo). ⏲️

@getsantry
Copy link
Contributor

getsantry bot commented Mar 30, 2023

Routing to @getsentry/workflow for triage, due by Monday, April 3rd at 9:15 am (sfo). ⏲️

@getsantry
Copy link
Contributor

getsantry bot commented Mar 31, 2023

Routing to @getsentry/workflow for triage, due by Tuesday, April 4th at 10:06 am (sfo). ⏲️

@scttcper
Copy link
Member

@igorsantos07 i think this would have to routed to the respective SDK teams. Is the JS sdk not submitting the logger in the same way as the php sdk? Is this the js browser SDK?

In the other issue it seems like you're trying to separate a project with multiple platforms, but this is more of an uphill battle since even internally we use separate projects since platforms basically map 1:1 with projects.

@github-actions
Copy link
Contributor

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants