Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPIKE] Check for possible client_sampled in tagging #51026

Closed
iambriccardo opened this issue Jun 15, 2023 · 2 comments
Closed

[SPIKE] Check for possible client_sampled in tagging #51026

iambriccardo opened this issue Jun 15, 2023 · 2 comments
Assignees

Comments

@iambriccardo
Copy link
Member

Right now the error tagging doesn't support client side sampling, that is, if a trace is sampled out by the head of the trace, this information is not propagated in the trace header (aka dsc). This means that from the perspective of dynamic sampling, we don't know whether the trace has been sampled out on the client and this could lead to false positives.

We would need to fix this by having the client SDKs add the client sampling decision in the dsc that will be attached to the error. This client sampling decision will work similarly to dynamic sampling, that is, if the head is sampled out all the children are sampled out and vice versa.

@ale-cota
Copy link
Contributor

Waiting for SDK work and overall tracking issue.

@matejminar matejminar changed the title Implement check for possible client_sampled in tagging SPIKE Check for possible client_sampled in tagging Jul 3, 2023
@iambriccardo iambriccardo changed the title SPIKE Check for possible client_sampled in tagging [SPIKE] Check for possible client_sampled in tagging Jul 4, 2023
@iambriccardo
Copy link
Member Author

Had a meeting with @sl0thentr0py @smeubank @cleptric @jan-auer and we agreed that the SDKs team will drive the effort to add the sampled field in the DSC and Relay will take that in consideration when performing tagging.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants