We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sentry/snuba 24.4.2
--no-skip-write
According to: https://github.com/getsentry/snuba/blob/24.4.2/snuba/cli/rust_consumer.py#L104-L109
I expect that consumer follow config flag --no-skip-write and write rows to clickhouse and correctly report it to logs
{"timestamp":"...","level":"INFO","fields":{"message":"Inserted 1 rows"},"target":"rust_snuba::strategies::clickhouse"}
Consumer actually writes to clickhouse with --no-skip-write, but reports that writing skipped, which looks like inverted interpretation of flag
{"timestamp":"...","level":"INFO","fields":{"message":"skipping write of 1 rows"},"target":"rust_snuba::strategies::clickhouse"}
If I run rust consumer with --skip-write flag, it stops writing to clickhouse, but reports {"message":"Inserted 1 rows"} in logs
--skip-write
{"message":"Inserted 1 rows"}
The text was updated successfully, but these errors were encountered:
I can confirm that the log output is swapped, but in terms of actual behavior the --skip-write flag should work correctly.
Sorry, something went wrong.
fix(rust): Fix incorrect logging output
0021c12
the `finish()` function returns whether the write happened, as such the logs were messed up. Fix #5847
#5920 this should fix the log
fix(rust): Fix incorrect logging output (#5920)
b7e0867
untitaker
Successfully merging a pull request may close this issue.
Environment
sentry/snuba 24.4.2
Steps to Reproduce
--no-skip-write
flagExpected Result
According to: https://github.com/getsentry/snuba/blob/24.4.2/snuba/cli/rust_consumer.py#L104-L109
I expect that consumer follow config flag
--no-skip-write
and write rows to clickhouse and correctly report it to logsActual Result
Consumer actually writes to clickhouse with
--no-skip-write
, but reports that writing skipped, which looks like inverted interpretation of flagIf I run rust consumer with
--skip-write
flag, it stops writing to clickhouse, but reports{"message":"Inserted 1 rows"}
in logsThe text was updated successfully, but these errors were encountered: