feat(kafka): Add the Snuba commit log compaction settings #4941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the compaction settings to match what we do in production. Note: We currently have "compact" instead of "compact,delete" defined in prod, but this should be fixed.
lynnagara
changed the title
Why not have this PR line up with production? Or is the plan to change production to "compact,delete"? |
|
Yeah, we need to change production. This caused an issue last week since we have changed the format of this topic and some years old data is never expired. Kicking this off in https://github.com/getsentry/ops/pull/8361. |
lynnagara
added a commit
to getsentry/arroyo
that referenced
this pull request
Oct 30, 2023
We experienced issues when deploying #295 to production. It was discovered that very old commit log entries are still present. This is likely because the commit log topic has cleanup.policy=compact set, which causes messages to never expire if they have a unique key. The process of fixing this is underway: getsentry/snuba#4941 and getsentry/ops#8361 However we have to keep support for the legacy commit log format around for a while until this work is complete.
lynnagara
added a commit
to getsentry/arroyo
that referenced
this pull request
Oct 30, 2023
We experienced issues when deploying #295 to production. It was discovered that very old commit log entries are still present. This is likely because the commit log topic has cleanup.policy=compact set, which causes messages to never expire if they have a unique key. The process of fixing this is underway: getsentry/snuba#4941 and getsentry/ops#8361 However we have to keep support for the legacy commit log format around for a while until this work is complete.
evanh
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the compaction settings to match what we do in production.
Note: We currently have "compact" instead of "compact,delete" defined in prod, but this should be fixed.