Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(ch-upgrades): create dist tables functionality #5737

Merged
merged 10 commits into from
Apr 11, 2024
Merged

Conversation

MeredithAnya
Copy link
Member

@MeredithAnya MeredithAnya commented Apr 10, 2024

Each time we run the series of these pipelines (fetcher, replayer, comparer) we first have to bring up nodes from backups and have our test clusters to work with. Doing the backup will restore the local tables, along with the data, but usually the dist tables are not backed up (if we change our backup process maybe we can change this) but as of now SRE folks would have to manually create the dist tables.

This aims to save the schemas of the dist tables during the fetching process, and when replaying for the first time we should be downloading the schema and using it to create the tables.

I tested this locally with my own gcs bucket

@MeredithAnya MeredithAnya requested a review from a team as a code owner April 10, 2024 00:31
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 14.03509% with 49 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (master@be207a9). Click here to learn what that means.

✅ All tests successful. No failed tests found ☺️

Files Patch % Lines
snuba/cli/query_replayer.py 0.00% 35 Missing ⚠️
snuba/cli/query_fetcher.py 0.00% 12 Missing ⚠️
snuba/clickhouse/upgrades/comparisons.py 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5737   +/-   ##
=========================================
  Coverage          ?   91.95%           
=========================================
  Files             ?      863           
  Lines             ?    41949           
  Branches          ?        0           
=========================================
  Hits              ?    38575           
  Misses            ?     3374           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

snuba/cli/query_fetcher.py Outdated Show resolved Hide resolved
snuba/cli/query_replayer.py Outdated Show resolved Hide resolved
snuba/cli/query_replayer.py Outdated Show resolved Hide resolved
snuba/cli/query_replayer.py Outdated Show resolved Hide resolved
snuba/cli/query_replayer.py Outdated Show resolved Hide resolved
snuba/cli/query_fetcher.py Outdated Show resolved Hide resolved
Co-authored-by: Nikhar Saxena <84807402+nikhars@users.noreply.github.com>
@MeredithAnya MeredithAnya enabled auto-merge (squash) April 11, 2024 18:54
@MeredithAnya MeredithAnya merged commit 72b5205 into master Apr 11, 2024
30 checks passed
@MeredithAnya MeredithAnya deleted the meredith/4-9-24 branch April 11, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants