bytes_scanned_window_policy DD metric #6081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xurui-c
force-pushed
the
rachel/windowMetrics
branch
from
4041c52
to
7585288
Compare
nachivrn
reviewed
Jul 2, 2024
xurui-c
force-pushed
the
rachel/windowMetrics
branch
from
7585288
to
e2666d4
Compare
nachivrn
approved these changes
Jul 2, 2024
|
PR reverted: ba3e5ed |
getsentry-bot
added a commit
that referenced
this pull request
Jul 3, 2024
This reverts commit 8a00dca. Co-authored-by: ellisonmarks <125329741+ellisonmarks@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous PR, we emit a Sentry warning and a GCP log for every query throttled by Snuba's capacity management system. However, we quickly realized a large volume of queries were throttled.
A potential solution we came up with is to sample the number of throttled queries we emit warnings and logging for, but before this, we realized that every throttled query I manually inspected from GCP logs is throttled by BytesScannedWindowAllocationPolicy, a policy we plan on deprecating anyways. A possible explanation of this occurrence is that BytesScannedWindowPolicy does not reject queries - it only throttles them.
We use this PR to answer 2 questions: