fix: Using Hermes SourceMaps with non-hermes stackframes #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
approved these changes
Feb 18, 2020
Swatinem
force-pushed
the
fix/non-hermes
branch
from
324a8dd
to
ab4c1f5
Compare
jan-auer
approved these changes
Feb 18, 2020
7 tasks
|
This implies a sentry and sentry-cli release? |
|
@HazAT just |
|
Sweet |
|
|
cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a misunderstanding on my part. The
SourceMapHermesactually is not specific to Hermes at all. It’s just a SourceMap with additional scoping information. So it can be used without Hermes.