fix(debuginfo): Decompress GNU compressed debug sections correctly #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitsuhiko
approved these changes
Mar 3, 2020
untitaker
approved these changes
Mar 3, 2020
| let context = Ctx::new(container, endianness); | ||
| let (size, compressed) = if section_data.starts_with(b"ZLIB") { | ||
| // The GNU compression header is a 4 byte magic "ZLIB", followed by an 8-byte big-endian | ||
| // size prefix of the decompressed data. This adds up to 12 bytes of GNU header. |
There was a problem hiding this comment.
I was confused by the last sentence here because the "up to" made it sound like it can be smaller while the code didn't allow for that.
There was a problem hiding this comment.
Sorry, saw this too late. I can clarify this on master, if you like.
In my mind it read as "the numbers are adding up" to a sum :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes decompression of
.zdebug*GNU sections.