[debuginfo] No error in functions iterator on name errors #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swatinem
approved these changes
Mar 30, 2020
jan-auer
requested changes
Mar 30, 2020
debuginfo/src/dwarf.rs
Outdated
|
|
||
| let function = Function { | ||
| address: function_address, | ||
| size: function_size, | ||
| name: Name::with_language(name.unwrap_or_default(), self.language), | ||
| name: Name::with_language( | ||
| name.unwrap_or_else(|| Cow::from("<name omitted>")), |
There was a problem hiding this comment.
Could you leave this an empty string and coerce in the caller? We rely on this being empty in Sentry since we show our own placeholders which have semantic meaning.
debuginfo/src/dwarf.rs
Outdated
| let file = self | ||
| .resolve_file(row.file_index) | ||
| .ok() | ||
| .flatten() |
There was a problem hiding this comment.
Since both usages now only require an option, can you change the function signature to Option<FileInfo>?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It aims to fix: #195