Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support Swift 5.2 mangling #208

Merged
merged 6 commits into from
Apr 6, 2020
Merged

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Apr 5, 2020

Updates to Swift 5.2.1. Along with this, there are a few changes:

  • Added a script that auto-imports files and headers. Still requires to build the entirety of Swift, though :(
  • Requiring a C++14 compiler now. It's no longer sustainable to keep backwards compatibility.
  • Switched to Manylinux2010 since the Manylinux1 images cannot run a C++14 compiler.

Fixes #204

@jan-auer jan-auer requested review from mitsuhiko and a team April 5, 2020 16:59
@jan-auer jan-auer self-assigned this Apr 5, 2020
@jan-auer
Copy link
Member Author

jan-auer commented Apr 5, 2020

@mitsuhiko See ac63e8c for the manylinux-related changes.

Copy link
Member

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still requires to build the entirety of Swift, though :(

why is that? Does it generate some artifacts during the build?

@jan-auer jan-auer merged commit fa197cd into master Apr 6, 2020
@jan-auer jan-auer deleted the feat/demangle-swift-5.2 branch April 6, 2020 07:00
Comment on lines +32 to +35
5. Build the complete swift project (be very patient, this may take long):
```
$ cd swift
$ ./utils/build-script

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can use --skip-build here. The headers in build/Ninja-DebugAssert/*-macosx-x86_64/include are still generated when --skip-build is used. This avoids building all of swift.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

swift-demangle needs to be updated for Swift 5.2
3 participants