feat(common): Add Path utilities for dSYM structures #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swatinem
reviewed
Apr 7, 2020
| /// | ||
| /// # Examples | ||
| /// | ||
| /// ```no_run |
There was a problem hiding this comment.
oh, and I thought these were actually real tests. Would you mind changing them in a way that they use any of the fixtures that we have? Would be nice to have coverage here.
There was a problem hiding this comment.
These are doc tests, so I cannot use our fixtures (and it also makes little sense). These docs are modelled after the std::path::Path docs.
However, I agree that this should be tested, let me add some tests.
flub
approved these changes
Apr 7, 2020
Swatinem
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements utilities for dealing with
dSYMfolder structures. They can check for a dSYM folder structure, resolve the dSYM parent from a deep path, and resolve the deep path from the parent folder.sentry-clipartially implements this logic already, so we can reduce some duplicate code here. Also, the examples used to require that one declares the full path to a dSYM file, but this is just unnecessary.