Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(minidump): Skip TooManyRegisterRules errors in CFI #219

Merged
merged 1 commit into from
Apr 16, 2020
Merged

fix(minidump): Skip TooManyRegisterRules errors in CFI #219

merged 1 commit into from
Apr 16, 2020

Conversation

jan-auer
Copy link
Member

Gimli has a hardcoded limit of 32 register rules per CFI row. There are rare occurrences where this limit is exceeded for single rows. In this case, it does not make sense to abort conversion, and instead just skip the row.

Ref gimli-rs/gimli#487

@jan-auer jan-auer requested a review from a team April 16, 2020 12:58
@jan-auer jan-auer self-assigned this Apr 16, 2020
@jan-auer jan-auer merged commit 9130d84 into master Apr 16, 2020
@jan-auer jan-auer deleted the fix/cfi-too-many-register-rules branch April 16, 2020 15:06
jan-auer added a commit that referenced this pull request Apr 16, 2020
@jan-auer
Merge branch 'master' into build/bump-cpp-demangle
02a6b42 
* master:
  fix(minidump): Skip TooManyRegisterRules errors in CFI (#219)
  feat(examples): Add a --trace flag to the run script
  fix(minidump): Get CFI info from eh_frame even if err in debug_frame (#218)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swatinem Swatinem Swatinem approved these changes

Assignees

@jan-auer jan-auer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jan-auer @Swatinem