Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): Broken compilation with -Clink-dead-code #225

Merged
merged 1 commit into from
Apr 22, 2020
Merged

fix(build): Broken compilation with -Clink-dead-code #225

merged 1 commit into from
Apr 22, 2020

Conversation

calixteman
Copy link
Contributor

@calixteman calixteman commented Apr 22, 2020 •
edited
Loading

It aims to fix issue #224.

@calixteman calixteman requested a review from a team April 22, 2020 15:49
@jan-auer jan-auer changed the title [demangle] Broken compilation when -Clink-dead-code is passed to rustc fix(build): Broken compilation when -Clink-dead-code is passed to rustc Apr 22, 2020
@jan-auer jan-auer changed the title fix(build): Broken compilation when -Clink-dead-code is passed to rustc fix(build): Broken compilation with -Clink-dead-code Apr 22, 2020
jan-auer
jan-auer approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@jan-auer jan-auer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jan-auer jan-auer merged commit 43c200d into getsentry:master Apr 22, 2020
jan-auer added a commit that referenced this pull request Apr 22, 2020
@jan-auer
Merge branch 'master' into build/bump-cpp-demangle
d0530b4 
* master:
  fix(symcache): Use same instruction address for full lookup (#226)
  feat(examples): Add a naive addr2line example (#222)
  fix(build): Broken compilation with -Clink-dead-code (#225)
  fix(debuginfo): Patch all parent line records of inlinees in DWARF (#223)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-auer jan-auer jan-auer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@calixteman @jan-auer