Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(elf): Consider sections of type SHT_MIPS_DWARF #317

Merged
merged 1 commit into from
Jan 29, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions symbolic-debuginfo/src/elf.rs
Original file line number Diff line number Diff line change
Expand Up @@ -307,9 +307,9 @@ impl<'data> ElfObject<'data> {
/// Locates and reads a section in an ELF binary.
fn find_section(&self, name: &str) -> Option<(bool, DwarfSection<'data>)> {
for header in &self.elf.section_headers {
// NB: Symbolic does not support MIPS, but if it did we would also need to check
// SHT_MIPS_DWARF sections.
if header.sh_type != elf::section_header::SHT_PROGBITS {
const SHT_MIPS_DWARF: u32 = 0x7000_001e;
const SHT_PROGBITS: u32 = elf::section_header::SHT_PROGBITS;
if !matches!(header.sh_type, SHT_PROGBITS | SHT_MIPS_DWARF) {
continue;
}

Expand Down