fix: Do not skip split functions #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been observed by multiple customers, using emscripten WASM files. These files include ranges that are broken in multiple ways, especially ranges going backwards were failing processing previously.
Previously, split top level functions were just skipped as they were causing trouble further down the road. With the fix to paper over broken WASM ranges which also sorts all the ranges, these problems go away, and what remains are possible issues when actually performing lookups using built SymCaches. The new SymCache format which is fundamentally based on instruction addrs instead of function start/size should further improve on this.
Swatinem
force-pushed
the
fix/dwarf-split-fns
branch
from
3eee961
to
80dcde5
Compare
Swatinem
changed the title
loewenheim
approved these changes
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, split top level functions were just skipped as they were causing trouble
further down the road. With the fix to paper over broken WASM ranges which also sorts all
the ranges, these problems go away, and what remains are possible issues when actually
performing lookups using built SymCaches.
The new SymCache format which is fundamentally based on instruction addrs instead of function
start/size should further improve on this.
This should fix https://getsentry.atlassian.net/browse/ISSUE-1291 and I verified this with the issue/debug file mentioned in that customer issue. However I would still hold off on this until we have the new symcache format, to avoid potential regressions here.