Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(unreal): Support the UE5 crash reporter [NATIVE-386] #449

Merged
merged 1 commit into from
Nov 18, 2021

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Nov 17, 2021

UE5 introduced a "CR1" marker at the beginning of crash archives. It indicates
that the header at the beginning of the file is valid. Previously, that header
was merely a placeholder and a second header at the end of the file contained
valid information. Unreal4Crash::parse now supports both versions by checking
for "CR1".

See https://github.com/EpicGames/UnrealEngine/commit/a0471b76577a64e5c4dad89a38dfe7d9611a65ef
Fixes getsentry/sentry#29940
cc @redxdev

@jan-auer jan-auer requested a review from a team November 17, 2021 07:40
@jan-auer
Copy link
Member Author

The file I was given to verify contains PII, so we cannot use it in the test suite. We'll need to create our own by checking out at least the UE version mentioned in the PR description.

cc @relaxolotl @Swatinem

@jan-auer jan-auer merged commit 0e405a8 into master Nov 18, 2021
@jan-auer jan-auer deleted the fix/ue5-cr1-version branch November 18, 2021 07:11
@jan-auer jan-auer changed the title fix(unreal): Support the UE5 crash reporter fix(unreal): Support the UE5 crash reporter [NATIVE-386] Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sentry no longer ingests unreal engine crash reports as of Unreal Engine 5.0
3 participants