Replace memmap #484
Merged
Replace memmap #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swatinem
approved these changes
Jan 5, 2022
|
The advisory links to the original issue danburkert/memmap-rs#90 where multiple people tried to get in contact with the maintainer. |
|
Thanks for clarifying! I guess its time to add automatic checking for this in CI, looks like we only have that for the rust SDK. |
|
glad this was finally tackled. interested what has changed since: #304 |
|
I think if it gets flagged via RUSTSEC advisories, that is a bit of an incentive to do the transition. Although the advisories can be a bit overeager sometimes. |
|
when can we get a release with this? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
memmaphas been marked as unmaintained for over a year now, this just replaces it with the maintainedmemmap2fork.